[flang-commits] [flang] [mlir] [mlir] Migrate aggregate builders to explicit properties (PR #219195)

[Krzysztof Drewniak via flang-commits]

================
@@ -2254,31 +2254,35 @@ struct TransposeLoadOpLowering
         if (numElements != 16)
           return emitNumElementsError(16, "gfx1250+");
         intrinsic =
-            ROCDL::DsLoadTr4_B64::create(rewriter, loc, rocdlResultType, srcPtr)
+            ROCDL::DsLoadTr4_B64::create(rewriter, loc, rocdlResultType, srcPtr,
+                                         ArrayAttr{}, ArrayAttr{}, ArrayAttr{})
                 .getResult();
         break;
       }
       case 6: {
         if (numElements != 16)
           return emitNumElementsError(16, "gfx1250+");
         intrinsic =
-            ROCDL::DsLoadTr6_B96::create(rewriter, loc, rocdlResultType, srcPtr)
+            ROCDL::DsLoadTr6_B96::create(rewriter, loc, rocdlResultType, srcPtr,
+                                         ArrayAttr{}, ArrayAttr{}, ArrayAttr{})
                 .getResult();
         break;
       }
       case 8: {
         if (numElements != 8)
           return emitNumElementsError(8, "gfx1250+");
         intrinsic =
-            ROCDL::DsLoadTr8_B64::create(rewriter, loc, rocdlResultType, srcPtr)
+            ROCDL::DsLoadTr8_B64::create(rewriter, loc, rocdlResultType, srcPtr,
+                                         ArrayAttr{}, ArrayAttr{}, ArrayAttr{})
----------------
krzysz00 wrote:

These might want the /*value_name=*/ inlays, and might not need the types?

https://github.com/llvm/llvm-project/pull/219195