[flang-commits] [flang] [flang][OpenMP] Replace modifier verification with a generic one (PR #220675)

[Krzysztof Parzyszek via flang-commits]

================
@@ -2947,48 +2948,15 @@ void OmpStructureChecker::ChecksOnOrderedAsStandalone() {
     context_.Say(GetContext().clauseSource,
         "THREADS and SIMD clauses are not allowed when ORDERED construct is a standalone construct with no ORDERED region"_err_en_US);
   }
-
-  int dependSinkCount{0}, dependSourceCount{0};
----------------
kparzysz wrote:

The thing is that I can't find any indication in the spec that these were actual restrictions.  We checked two things (across multiple clauses):
1. that SOURCE should only appear once, and 
2. that SOURCE and SINK are mutually exclusive.
There is nothing in the spec(s) in the descriptions of the DEPEND/DOACROSS clause that actually says that.  There are restrictions on a single clause, but not on repeated occurrences of the clause.

@dreachem: What are your thoughts on this?  Should we continue to run these two checks?

https://github.com/llvm/llvm-project/pull/220675