[flang-commits] [flang] [Flang][Semantics] Diagnose missing MODULE prefix in submodule procedures (PR #197173)

[Eugene Epshteyn via flang-commits]

================
@@ -5771,6 +5771,24 @@ const Symbol *SubprogramVisitor::CheckExtantProc(
 Symbol *SubprogramVisitor::PushSubprogramScope(const parser::Name &name,
     Symbol::Flag subpFlag, const parser::LanguageBindingSpec *bindingSpec,
     bool hasModulePrefix) {
+  if (!inInterfaceBlock() && currScope().IsSubmodule() && !hasModulePrefix) {
+    const Scope &parent{currScope().parent()};
+    if (parent.IsModule() || parent.IsSubmodule()) {
+      if (const Symbol *host{parent.FindSymbol(name.source)}) {
+        const Symbol &hostUlt{host->GetUltimate()};
+        const auto *hostSubp{hostUlt.detailsIf<SubprogramDetails>()};
+        if (hostSubp && hostSubp->isInterface() &&
+            hostUlt.attrs().test(Attr::MODULE)) {
----------------
eugeneepshteyn wrote:

Please look into `IsSeparateModuleProcedureInterface()`

https://github.com/llvm/llvm-project/pull/197173