[flang-commits] [flang] [llvm] [Flang] KIND De-templatization (PR #216960)

[Michael Kruse via flang-commits]

================
@@ -1033,9 +1034,9 @@ MaybeExpr ExpressionAnalyzer::Analyze(const parser::LogicalLiteralConstant &x) {
   auto kind{AnalyzeKindParam(std::get<std::optional<parser::KindParam>>(x.t),
       GetDefaultKind(TypeCategory::Logical))};
   bool value{std::get<bool>(x.t)};
-  auto result{common::SearchTypes(
-      TypeKindVisitor<TypeCategory::Logical, Constant, bool>{
-          kind, std::move(value)})};
+  auto result{SearchTypes(
+      TypeKindVisitor<TypeCategory::Logical, Constant, value::LogicalValue>{
+          kind, value::LogicalValue{kind, value}})};
----------------
Meinersbur wrote:

The `ConstantBase` templated constructors effectively didn't allow conversion

[`c598e35` (this PR)](https://github.com/llvm/llvm-project/pull/216960/changes/c598e35d5ec62350a4d28044a551d640f6eb854d)

https://github.com/llvm/llvm-project/pull/216960