[flang-commits] [flang] [flang] Fix incorrect reallocation for host-associated main-program coarrays #231233 (PR #233361)

[via flang-commits]

================
@@ -0,0 +1,52 @@
+! RUN: %flang_fc1 -emit-hlfir -fcoarray %s -o - | FileCheck %s
+
+program p
+  integer :: c[*]
+  c = 5
+  if (this_image() == 1) call show
+contains
+  subroutine show
+    c = c + 5
+  end subroutine
+end program
+
+! CHECK-LABEL: func.func @_QQmain() attributes {fir.bindc_name = "P"} {
+! CHECK: %[[VAL_0:.*]] = fir.alloca !fir.array<0xi64>
+! CHECK: %[[VAL_1:.*]] = fir.alloca !fir.array<1xi64>
+! CHECK: %[[VAL_2:.*]] = fir.dummy_scope : !fir.dscope
+! CHECK: %[[VAL_3:.*]] = fir.address_of(@_QFEc) : !fir.ref<i32>
+! CHECK: %[[C1_I64:.*]] = arith.constant 1 : i64
+! CHECK: %[[C0:.*]] = arith.constant 0 : index
+! CHECK: %[[VAL_4:.*]] = fir.coordinate_of %[[VAL_1]], %[[C0]] : (!fir.ref<!fir.array<1xi64>>, index) -> !fir.ref<i64>
+! CHECK: fir.store %[[C1_I64]] to %[[VAL_4]] : !fir.ref<i64>
+! CHECK: %[[VAL_5:.*]] = fir.embox %[[VAL_1]] : (!fir.ref<!fir.array<1xi64>>) -> !fir.box<!fir.array<1xi64>>
+! CHECK: %[[VAL_6:.*]] = fir.embox %[[VAL_0]] : (!fir.ref<!fir.array<0xi64>>) -> !fir.box<!fir.array<0xi64>>
+! CHECK: mif.alloc_coarray %[[VAL_3]] lcobounds %[[VAL_5]] ucobounds %[[VAL_6]] uniq_name("_QFEc") : (!fir.ref<i32>, !fir.box<!fir.array<1xi64>>, !fir.box<!fir.array<0xi64>>) -> ()
+! CHECK: %[[VAL_7:.*]]:2 = hlfir.declare %[[VAL_3]] uniq_name("_QFEc") fortran_attrs<internal_assoc> : (!fir.ref<i32>) -> (!fir.ref<i32>, !fir.ref<i32>)
+! CHECK: %[[C5_I32:.*]] = arith.constant 5 : i32
+! CHECK: hlfir.assign %[[C5_I32]] to %[[VAL_7]]#0 : i32, !fir.ref<i32>
+! CHECK: %[[VAL_8:.*]] = mif.this_image : () -> i32
+! CHECK: %[[C1_I32:.*]] = arith.constant 1 : i32
+! CHECK: %[[VAL_9:.*]] = arith.cmpi eq, %[[VAL_8]], %[[C1_I32]] : i32
+! CHECK: fir.if %[[VAL_9]] {
+! CHECK:   fir.call @_QFPshow() fastmath<contract> : () -> ()
+! CHECK: }
+! CHECK: return
+! CHECK: }
+
+! mif.alloc_coarray must not appear in the body of @_QFPshow
----------------
MattPD wrote:

Could the executable checks exclude `mif.alloc_coarray` throughout `show`? The parent compiler emits the duplicate allocation inside `show`, but its actual output passes all the unchanged FileCheck assertions. The positive checks skip the allocation between `fir.address_of` and `hlfir.declare`; the comment alone does not enforce its absence.

https://github.com/llvm/llvm-project/pull/233361