[flang-commits] [flang] [flang] Use correct dummy argument name X for IEEE_IS_NAN/IS_NEGATIVE/IS_NORMAL (PR #233757)

[via flang-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-flang-semantics

Author: Cyrus Ding (dingcyrus)

<details>
<summary>Changes</summary>

Also adds flang/test/Semantics/ieee_keywords.f90 covering positive X=, positional, and negative A= references.
Verified locally: the new test plus all existing IEEE Semantics/Evaluate/Lower tests pass; flang/test/Semantics, flang/test/Evaluate, flang/test/Lower/Intrinsics show no diff against an unpatched baseline.

Fixes https://github.com/llvm/llvm-project/issues/233449

---
Full diff: https://github.com/llvm/llvm-project/pull/233757.diff


2 Files Affected:

- (modified) flang/lib/Evaluate/intrinsics.cpp (+3-3) 
- (added) flang/test/Semantics/ieee_keywords.f90 (+17) 


``````````diff
diff --git a/flang/lib/Evaluate/intrinsics.cpp b/flang/lib/Evaluate/intrinsics.cpp
index f7ea85a455ac2e..5ba4e73198b882 100644
--- a/flang/lib/Evaluate/intrinsics.cpp
+++ b/flang/lib/Evaluate/intrinsics.cpp
@@ -1094,9 +1094,9 @@ static const IntrinsicInterface genericIntrinsicFunction[]{
     {"__builtin_ieee_int",
         {{"a", AnyFloating}, {"round", IeeeRoundType}, DefaultingKIND},
         KINDInt},
-    {"__builtin_ieee_is_nan", {{"a", AnyFloating}}, DefaultLogical},
-    {"__builtin_ieee_is_negative", {{"a", AnyFloating}}, DefaultLogical},
-    {"__builtin_ieee_is_normal", {{"a", AnyFloating}}, DefaultLogical},
+    {"__builtin_ieee_is_nan", {{"x", AnyFloating}}, DefaultLogical},
+    {"__builtin_ieee_is_negative", {{"x", AnyFloating}}, DefaultLogical},
+    {"__builtin_ieee_is_normal", {{"x", AnyFloating}}, DefaultLogical},
     {"__builtin_ieee_next_after", {{"x", SameReal}, {"y", AnyReal}}, SameReal},
     {"__builtin_ieee_next_down", {{"x", SameReal}}, SameReal},
     {"__builtin_ieee_next_up", {{"x", SameReal}}, SameReal},
diff --git a/flang/test/Semantics/ieee_keywords.f90 b/flang/test/Semantics/ieee_keywords.f90
new file mode 100644
index 00000000000000..07d4f6edbc4f51
--- /dev/null
+++ b/flang/test/Semantics/ieee_keywords.f90
@@ -0,0 +1,17 @@
+! RUN: %python %S/test_errors.py %s %flang_fc1
+! The mandatory dummy argument of the IEEE_ARITHMETIC classification inquiry
+! functions is named X in the standard, not A.
+use ieee_arithmetic, only : ieee_is_nan, ieee_is_negative, ieee_is_normal
+implicit none
+real :: v = 1.0
+print *, ieee_is_nan(v)
+print *, ieee_is_nan(X = v)
+print *, ieee_is_negative(X = v)
+print *, ieee_is_normal(X = v)
+!ERROR: unknown keyword argument to intrinsic '__builtin_ieee_is_nan'
+print *, ieee_is_nan(A = v)
+!ERROR: unknown keyword argument to intrinsic '__builtin_ieee_is_negative'
+print *, ieee_is_negative(A = v)
+!ERROR: unknown keyword argument to intrinsic '__builtin_ieee_is_normal'
+print *, ieee_is_normal(A = v)
+end

``````````

</details>


https://github.com/llvm/llvm-project/pull/233757