[flang-commits] [flang] [flang] Lower Cray pointee references without a runtime call. (PR #230699)

[via flang-commits]

================
@@ -1275,6 +1275,36 @@ def fir_BoxAddrOp
   }];
 }
 
+def fir_BoxSetAddrOp : fir_Op<"box_set_addr", []> {
----------------
jeanPerier wrote:

I think you need to add `DeclareOpInterfaceMethods<MemoryEffectsOpInterface>` and implement the same handling for VOLATILE as fir.store to properly deals with the cases where the cray pointer is VOLATILE. I am not sure how common that is, but that looks possible to me, and in general once this operation is here, it may start being used by other things where VOLATILE matters.

The codegen will need to propagate the volatile aspect on the llvm.store when relevant.

https://github.com/llvm/llvm-project/pull/230699