[flang-commits] [flang] [Flang] Diagnose DATA on PDT instance components as unimplemented (PR #213598)
via flang-commits
flang-commits at lists.llvm.org
Tue Oct 6 05:06:23 PDT 2026
ejose02 wrote:
> The PR title suggests that this PR fixes the underlying issue, but the first paragraph of the description clarifies that it only emits a better diagnostic. Please fix the title to better reflect what this fix actually does.
>
> The PR description will become the commit message once this is merged. The title of the PR will be the first line in that message. As it is, the description has too much unnecessary detail, most of which is not appropriate for a commit message (some guidelines are provided in LLVM's [developer documentation](https://llvm.org/docs/DeveloperPolicy.html#commit-messages). It is probably sufficient to leave only the first paragraph and the "Fixes" line and omit the rest. You can add a follow-up comment on this PR to provide that detail if you think it will be useful for reviewers.
>
> I generally don't review PR's related to semantics - hopefully one of the other tagged reviewers can take a look.
>
> [EDIT: wording]
Thanks @tarunprabhu . I have updated the title and the description.
https://github.com/llvm/llvm-project/pull/213598
More information about the flang-commits
mailing list