[flang-commits] [flang] [llvm] [Flang] Introduce common::numeric_limits (PR #228108)

[Eugene Epshteyn via flang-commits]

https://github.com/eugeneepshteyn commented:

LGTM with some suggestions and typo fixes.

Also, please check that current PR description corresponds to reality.

> Usually I would agree with the instinct to minimise the code churn; however, in this case I'm worried it could be too easy to forget to use common::numeric_limits rather than std::numeric_limits. In my opinion, using only common::numeric_limits in all cases makes the convention more visible in the codebase (both for humans and AI).

I agree with this. I would recommend to be consistent here and use common::numeric_limits everywhere.

https://github.com/llvm/llvm-project/pull/228108