[flang-commits] [flang] [llvm] [flang-rt] Extension: accept '!' as value separator in NAMELIST input (PR #200441)

via flang-commits flang-commits at lists.llvm.org
Fri May 29 09:04:03 PDT 2026


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- flang-rt/lib/runtime/edit-input.cpp flang-rt/lib/runtime/io-stmt.cpp flang-rt/unittests/Runtime/Namelist.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/flang-rt/unittests/Runtime/Namelist.cpp b/flang-rt/unittests/Runtime/Namelist.cpp
index b81d9ec9d..aaa3c1d35 100644
--- a/flang-rt/unittests/Runtime/Namelist.cpp
+++ b/flang-rt/unittests/Runtime/Namelist.cpp
@@ -382,8 +382,8 @@ TEST(NamelistTests, BangAsValueSeparator) {
           std::vector<int>{}, std::vector<std::complex<float>>{{0.f, 0.f}})};
   OwningPtr<Descriptor> cDesc{MakeArray<TypeCategory::Character, 1>(
       std::vector<int>{}, std::vector<std::string>{"        "}, 8)};
-  const NamelistGroup::Item items[]{{"i", *iDesc}, {"r", *rDesc},
-      {"l", *lDesc}, {"z", *zDesc}, {"c", *cDesc}};
+  const NamelistGroup::Item items[]{{"i", *iDesc}, {"r", *rDesc}, {"l", *lDesc},
+      {"z", *zDesc}, {"c", *cDesc}};
   const NamelistGroup group{"nml", 5, items};
   // No space before any '!' — the '!' must still terminate each value
   // and start a comment that runs to end of record.  Inside the character

``````````

</details>


https://github.com/llvm/llvm-project/pull/200441


More information about the flang-commits mailing list