[flang-commits] [flang] [flang][OpenMP] Remove unnecessary code from OmpVisitor, NFC (PR #198865)

[via flang-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

The build failed before running any tests. Click on a failure below to see the details.

<details>
<summary>[code=4294967295] bin/bbc.exe</summary>

```
FAILED: [code=4294967295] bin/bbc.exe
C:\Windows\system32\cmd.exe /C "cd . && C:\BuildTools\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe -E vs_link_exe --msvc-ver=1944 --intdir=tools\flang\tools\bbc\CMakeFiles\bbc.dir --rc="C:\Program Files (x86)\Windows Kits\10\bin\10.0.26100.0\x64\rc.exe" --mt="C:\Program Files (x86)\Windows Kits\10\bin\10.0.26100.0\x64\mt.exe" --manifests  -- C:\clang\clang-msvc\bin\lld-link.exe /nologo @CMakeFiles\bbc.rsp  /out:bin\bbc.exe /implib:lib\bbc.lib /pdb:bin\bbc.pdb /version:0.0 /MANIFEST:NO /INCREMENTAL:NO /subsystem:console  /STACK:10000000 && cd ."
LINK: command "C:\clang\clang-msvc\bin\lld-link.exe /nologo @CMakeFiles\bbc.rsp /out:bin\bbc.exe /implib:lib\bbc.lib /pdb:bin\bbc.pdb /version:0.0 /MANIFEST:NO /INCREMENTAL:NO /subsystem:console /STACK:10000000" failed (exit code 1) with the following output:
lld-link: error: undefined symbol: public: static bool __cdecl Fortran::semantics::OmpVisitor::HasDataEnvironment(enum llvm::omp::Directive)
>>> referenced by FortranSemantics.lib(resolve-names.cpp.obj):(??@87ceb04cc67ae0118b8a6178fba2011b@)
>>> referenced by FortranSemantics.lib(resolve-names.cpp.obj):(??@87ceb04cc67ae0118b8a6178fba2011b@)
>>> referenced by FortranSemantics.lib(resolve-names.cpp.obj):(public: static void __cdecl Fortran::parser::detail::ParseTreeVisitorLookupScope::Walk<struct Fortran::parser::OpenMPConstruct, class Fortran::semantics::ResolveNamesVisitor>(struct Fortran::parser::OpenMPConstruct const &, class Fortran::semantics::ResolveNamesVisitor &))
>>> referenced 3 more times
```
</details>
<details>
<summary>[code=4294967295] tools/flang/unittests/Frontend/FlangFrontendTests.exe</summary>

```
FAILED: [code=4294967295] tools/flang/unittests/Frontend/FlangFrontendTests.exe
C:\Windows\system32\cmd.exe /C "cd . && C:\BuildTools\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe -E vs_link_exe --msvc-ver=1944 --intdir=tools\flang\unittests\Frontend\CMakeFiles\FlangFrontendTests.dir --rc="C:\Program Files (x86)\Windows Kits\10\bin\10.0.26100.0\x64\rc.exe" --mt="C:\Program Files (x86)\Windows Kits\10\bin\10.0.26100.0\x64\mt.exe" --manifests  -- C:\clang\clang-msvc\bin\lld-link.exe /nologo @CMakeFiles\FlangFrontendTests.rsp  /out:tools\flang\unittests\Frontend\FlangFrontendTests.exe /implib:tools\flang\unittests\Frontend\FlangFrontendTests.lib /pdb:tools\flang\unittests\Frontend\FlangFrontendTests.pdb /version:0.0 /MANIFEST:NO /INCREMENTAL:NO /subsystem:console  /STACK:10000000 && cd ."
LINK: command "C:\clang\clang-msvc\bin\lld-link.exe /nologo @CMakeFiles\FlangFrontendTests.rsp /out:tools\flang\unittests\Frontend\FlangFrontendTests.exe /implib:tools\flang\unittests\Frontend\FlangFrontendTests.lib /pdb:tools\flang\unittests\Frontend\FlangFrontendTests.pdb /version:0.0 /MANIFEST:NO /INCREMENTAL:NO /subsystem:console /STACK:10000000" failed (exit code 1) with the following output:
lld-link: error: undefined symbol: public: static bool __cdecl Fortran::semantics::OmpVisitor::HasDataEnvironment(enum llvm::omp::Directive)
>>> referenced by FortranSemantics.lib(resolve-names.cpp.obj):(??@87ceb04cc67ae0118b8a6178fba2011b@)
>>> referenced by FortranSemantics.lib(resolve-names.cpp.obj):(??@87ceb04cc67ae0118b8a6178fba2011b@)
>>> referenced by FortranSemantics.lib(resolve-names.cpp.obj):(public: static void __cdecl Fortran::parser::detail::ParseTreeVisitorLookupScope::Walk<struct Fortran::parser::OpenMPConstruct, class Fortran::semantics::ResolveNamesVisitor>(struct Fortran::parser::OpenMPConstruct const &, class Fortran::semantics::ResolveNamesVisitor &))
>>> referenced 3 more times
```
</details>
<details>
<summary>[code=4294967295] tools/flang/unittests/Semantics/OpenMPUtilsTests.exe</summary>

```
FAILED: [code=4294967295] tools/flang/unittests/Semantics/OpenMPUtilsTests.exe
C:\Windows\system32\cmd.exe /C "cd . && C:\BuildTools\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe -E vs_link_exe --msvc-ver=1944 --intdir=tools\flang\unittests\Semantics\CMakeFiles\OpenMPUtilsTests.dir --rc="C:\Program Files (x86)\Windows Kits\10\bin\10.0.26100.0\x64\rc.exe" --mt="C:\Program Files (x86)\Windows Kits\10\bin\10.0.26100.0\x64\mt.exe" --manifests  -- C:\clang\clang-msvc\bin\lld-link.exe /nologo @CMakeFiles\OpenMPUtilsTests.rsp  /out:tools\flang\unittests\Semantics\OpenMPUtilsTests.exe /implib:tools\flang\unittests\Semantics\OpenMPUtilsTests.lib /pdb:tools\flang\unittests\Semantics\OpenMPUtilsTests.pdb /version:0.0 /MANIFEST:NO /INCREMENTAL:NO /subsystem:console  /STACK:10000000 && cd ."
LINK: command "C:\clang\clang-msvc\bin\lld-link.exe /nologo @CMakeFiles\OpenMPUtilsTests.rsp /out:tools\flang\unittests\Semantics\OpenMPUtilsTests.exe /implib:tools\flang\unittests\Semantics\OpenMPUtilsTests.lib /pdb:tools\flang\unittests\Semantics\OpenMPUtilsTests.pdb /version:0.0 /MANIFEST:NO /INCREMENTAL:NO /subsystem:console /STACK:10000000" failed (exit code 1) with the following output:
lld-link: error: undefined symbol: public: static bool __cdecl Fortran::semantics::OmpVisitor::HasDataEnvironment(enum llvm::omp::Directive)
>>> referenced by FortranSemantics.lib(resolve-names.cpp.obj):(??@87ceb04cc67ae0118b8a6178fba2011b@)
>>> referenced by FortranSemantics.lib(resolve-names.cpp.obj):(??@87ceb04cc67ae0118b8a6178fba2011b@)
>>> referenced by FortranSemantics.lib(resolve-names.cpp.obj):(public: static void __cdecl Fortran::parser::detail::ParseTreeVisitorLookupScope::Walk<struct Fortran::parser::OpenMPConstruct, class Fortran::semantics::ResolveNamesVisitor>(struct Fortran::parser::OpenMPConstruct const &, class Fortran::semantics::ResolveNamesVisitor &))
>>> referenced 3 more times
```
</details>
<details>
<summary>[code=4294967295] bin/flang.exe</summary>

```
FAILED: [code=4294967295] bin/flang.exe
C:\Windows\system32\cmd.exe /C "cd . && C:\BuildTools\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe -E vs_link_exe --msvc-ver=1944 --intdir=tools\flang\tools\flang-driver\CMakeFiles\flang.dir --rc="C:\Program Files (x86)\Windows Kits\10\bin\10.0.26100.0\x64\rc.exe" --mt="C:\Program Files (x86)\Windows Kits\10\bin\10.0.26100.0\x64\mt.exe" --manifests  -- C:\clang\clang-msvc\bin\lld-link.exe /nologo @CMakeFiles\flang.rsp  /out:bin\flang.exe /implib:lib\flang.lib /pdb:bin\flang.pdb /version:0.0 /MANIFEST:NO /INCREMENTAL:NO /subsystem:console  /STACK:10000000 && C:\Windows\system32\cmd.exe /C "cd /D C:\_work\llvm-project\llvm-project\build\tools\flang\tools\flang-driver && C:\BuildTools\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe -E copy C:/_work/llvm-project/llvm-project/build/bin/flang.exe C:/_work/llvm-project/llvm-project/build/./bin/flang-new.exe""
LINK: command "C:\clang\clang-msvc\bin\lld-link.exe /nologo @CMakeFiles\flang.rsp /out:bin\flang.exe /implib:lib\flang.lib /pdb:bin\flang.pdb /version:0.0 /MANIFEST:NO /INCREMENTAL:NO /subsystem:console /STACK:10000000" failed (exit code 1) with the following output:
lld-link: error: undefined symbol: public: static bool __cdecl Fortran::semantics::OmpVisitor::HasDataEnvironment(enum llvm::omp::Directive)
>>> referenced by FortranSemantics.lib(resolve-names.cpp.obj):(??@87ceb04cc67ae0118b8a6178fba2011b@)
>>> referenced by FortranSemantics.lib(resolve-names.cpp.obj):(??@87ceb04cc67ae0118b8a6178fba2011b@)
>>> referenced by FortranSemantics.lib(resolve-names.cpp.obj):(public: static void __cdecl Fortran::parser::detail::ParseTreeVisitorLookupScope::Walk<struct Fortran::parser::OpenMPConstruct, class Fortran::semantics::ResolveNamesVisitor>(struct Fortran::parser::OpenMPConstruct const &, class Fortran::semantics::ResolveNamesVisitor &))
>>> referenced 3 more times
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/198865