[flang-commits] [flang] [Flang] External subprograms should be allowed as proc_target in procedure pointers. (PR #183268)

[via flang-commits]

ShashwathiNavada wrote:

> Thanks for the update and the ping. A couple nits, and there are tests failing (you will probably need to move the fir.global generation after the func.func declarations in the tests). [edit, which you already pointed out, so yes, you can update them. Have you ran the llvm-test-suite to ensure end to end testing are OK?].
> 
> ```
>   Failed Tests (22):
>     Flang :: Fir/dispatch.f90
>     Flang :: Lower/CUDA/cuda-allocatable-device.cuf
>     Flang :: Lower/CUDA/cuda-allocatable.cuf
>     Flang :: Lower/CUDA/cuda-data-attribute.cuf
>     Flang :: Lower/CUDA/cuda-gpu-managed.cuf
>     Flang :: Lower/CUDA/cuda-mod.cuf
>     Flang :: Lower/CUDA/cuda-pointer-sync.cuf
>     Flang :: Lower/HLFIR/procedure-pointer-in-generics.f90
>     Flang :: Lower/OpenACC/acc-declare.f90
>     Flang :: Lower/OpenMP/block-use-predetermined-privatization.f90
>     Flang :: Lower/OpenMP/cray-pointers01.f90
>     Flang :: Lower/OpenMP/threadprivate-hlfir.f90
>     Flang :: Lower/OpenMP/threadprivate-real-logical-complex-derivedtype.f90
>     Flang :: Lower/OpenMP/threadprivate-use-association-2-hlfir.f90
>     Flang :: Lower/OpenMP/threadprivate-use-association.f90
>     Flang :: Lower/allocatable-globals.f90
>     Flang :: Lower/array-elemental-calls-char-dynamic.f90
>     Flang :: Lower/c-interoperability.f90
>     Flang :: Lower/dense-attributed-array.f90
>     Flang :: Lower/dispatch.f90
>     Flang :: Lower/pointer-default-init.f90
>     Flang :: Lower/polymorphic.f90
> ```

@jeanPerier Done! Sorry for the delayed response. I have now run the LLVM test suite, and all the tests appear to be running successfully.
Please let me know if there is anything else that needs to be done.
Thank you.

https://github.com/llvm/llvm-project/pull/183268