[flang-commits] [flang] [Flang] Fix -Wopen-mp-* and -Wopen-acc-* flag spellings (PR #188434)

[Eugene Epshteyn via flang-commits]

================
@@ -1048,6 +1048,17 @@ static bool parseDiagArgs(CompilerInvocation &res, llvm::opt::ArgList &args,
         const unsigned diagID = diags.getCustomDiagID(
             clang::DiagnosticsEngine::Error, "Unknown diagnostic option: -W%0");
         diags.Report(diagID) << wArg;
+      } else {
+        if (auto canonical{features.GetCanonicalSpelling(wArg)}) {
+          std::string suggestion{*canonical};
+          if (wArg.size() > 3 && wArg.substr(0, 3) == "no-") {
----------------
eugeneepshteyn wrote:

Would it work to change `wArgs` iteration loop to `for (llvm::StringRef wArg : wArgs) {` ? This would force `llvm::StringRef` creation for each element and we could consistently use its functionality everywhere.

https://github.com/llvm/llvm-project/pull/188434