[flang-commits] [flang] [flang][OpenACC] Generalize cross-region GOTO exit handling for all ACC region ops (PR #187613)

[via flang-commits]

================
@@ -1609,6 +1609,9 @@ class FirConverter : public Fortran::lower::AbstractConverter {
 
   void genBranch(mlir::Block *targetBlock) {
     assert(targetBlock && "missing unconditional target block");
+    if (Fortran::lower::genOpenACCRegionExitBranch(*builder, toLocation(),
+                                                   targetBlock))
+      return;
----------------
jeanPerier wrote:

Shouldn't the logic that is creating the store to the exitInfo.selector be moved to `genOpenACCRegionExitBranch` for this call to be valid here?

Otherwise, this may just be skipping the branch creation assuming the branch will be created later, but nothing was added to the accRegionExitStack here.

https://github.com/llvm/llvm-project/pull/187613