[flang-commits] [flang] [flang][OpenMP] Support user-defined declare reduction with derived types (PR #184897)

[Tom Eccles via flang-commits]

https://github.com/tblah commented:

Thanks for the update. The content of the tests looks good to me, so just some nitpicky comments to get the code to a state which is easier to understand.

Please also add a test featuring a derived type with a constructor and destructor (or whatever that is called in Fortran) to make sure these are handled correctly (it should be handled by `populateByRefInitAndCleanupRegion`, which already does this for privatisation of derived types). Perhaps a good test would be a non-trivial user-defined initializer combined with a constructor so we can see that these are generated in the correct order.

https://github.com/llvm/llvm-project/pull/184897