[flang-commits] [flang] [flang][OpenMP] Support user-defined declare reduction with derived types (PR #184897)
via flang-commits
flang-commits at lists.llvm.org
Mon Mar 9 08:54:24 PDT 2026
MattPD wrote:
@jsjodin, @kparzysz, @tblah, and @Leporacanthicus: Hey, let me know if you can take a look, as you may be familiar with this part of the codebase (also have a few related questions).
@kparzysz In commit 63e70c0 I've seen `ReductionProcessor::getReductionType` went from `Fortran::parser::DefinedOperator::IntrinsicOperator intrinsicOp` to `omp::clause::DefinedOperator::IntrinsicOperator intrinsicOp`. I wonder if this would still be applicable instead of `getRedIdFromParserIntrOp` I had to go for in the PR (as I need to convert `parser::DefinedOperator::IntrinsicOperator` to `ReductionProcessor::ReductionIdentifier` to be able to use `ReductionProcessor::getReductionName` in `genOMP` for `parser::OpenMPDeclareReductionConstruct`)?
@tblah and @Leporacanthicus: I still consistent with what you were going for in f46f5a0 (adding "force-byref-reduction"; when you've mentioned that passing by reference will be useful for array and derived type reductions (e.g. to move allocation inside of the init region))?.
https://github.com/llvm/llvm-project/pull/184897
More information about the flang-commits
mailing list