[flang-commits] [flang] [Flang][OpenMP] DEFAULT(NONE) error checking on implicit references (PR #182214)

[Leandro Lupori via flang-commits]

luporl wrote:

> It looks like `ResolveSeqLoopIndexInParallelOrTaskConstruct()` should be setting the loop index var private in the enclosing parallel in the way @dreachem describes, but it isn't behaving correctly.

A possible cause is that `ResolveSeqLoopIndexInParallelOrTaskConstruct()` is being called after `CreateImplicitSymbols()` in some cases, as this depends on the order the parse tree is visited.
That's why `ResolveSeqLoopIndexInParallelOrTaskConstruct()` uses `SetSymbolDSA()`, that first clears DSA flags, that could have been set by `CreateImplicitSymbols()` or other functions, before applying its own.

https://github.com/llvm/llvm-project/pull/182214