[flang-commits] [flang] [flang] Fix segfault in CSHIFT/EOSHIFT with dynamically optional DIM (PR #184431)

[Slava Zakharin via flang-commits]

================
@@ -322,10 +322,11 @@ llvm::SmallVector<mlir::Value> HlfirTransformationalIntrinsic::getOperandVector(
       valArg = loadBoxAddress(arg);
     } else if (argRules.handleDynamicOptional) {
       if (argRules.lowerAs == fir::LowerIntrinsicArgAs::Value) {
-        if (arg->handleDynamicOptional())
+        if (arg->handleDynamicOptional()) {
           valArg = loadOptionalValue(*arg);
-        else
+        } else {
           valArg = loadTrivialScalar(*arg);
+        }
----------------
vzakhari wrote:

nit: this is an unrelated change, and we should not be using braces in this case.

https://github.com/llvm/llvm-project/pull/184431