[flang-commits] [flang] [llvm] [flang][OpenMP] Split DEFAULT into DEFAULT(dsa) and DEFAULT(variant) (PR #212128)

[Krzysztof Parzyszek via flang-commits]

================
@@ -147,13 +147,19 @@ def OMPC_Counts : Clause<[Spelling<"counts">]> {
   let clangClass = "OMPCountsClause";
 }
 def OMPC_Default : Clause<[Spelling<"default">]> {
+  // This is for default DSA.
+  // For the "otherwise" clause, use OMPC_DefaultVariant.
   let clangClass = "OMPDefaultClause";
   let flangClass = "OmpDefaultClause";
 }
 def OMPC_DefaultMap : Clause<[Spelling<"defaultmap">]> {
   let clangClass = "OMPDefaultmapClause";
   let flangClass = "OmpDefaultmapClause";
 }
+def OMPC_DefaultVariant : Clause<[Spelling<"default">]> {
----------------
kparzysz wrote:

There are already cases when this ambiguity can happen, so I just added a comment in DirectiveEmitter.cpp that this is a possibility (and when it can happen).

https://github.com/llvm/llvm-project/pull/212128