[flang-commits] [flang] [llvm] [flang][OpenMP] Split DEFAULT into DEFAULT(dsa) and DEFAULT(variant) (PR #212128)

[Sairudra More via flang-commits]

================
@@ -654,8 +654,8 @@ Copyprivate make(const parser::OmpClause::Copyprivate &inp,
 // has been superseded by the OTHERWISE clause.
 // Disambiguate this in this representation: for the DSA case, create Default,
 // and in the other case create Otherwise.
-Default makeDefault(const parser::OmpClause::Default &inp,
-                    semantics::SemanticsContext &semaCtx) {
+Default make(const parser::OmpClause::Default &inp,
----------------
Saieiei wrote:

Nit: this comment still describes the old union-based representation. Disambiguation now happens in the parser, and this function handles only the DSA form. Could we update or remove it? The comment above `OmpAttributeVisitor::Post(const OmpDefaultClause &)` appears stale for the same reason.

https://github.com/llvm/llvm-project/pull/212128