[flang-commits] [flang] [flang][NFC] Delete the legacy expression lowering (ConvertExpr.cpp) and its support files (PR #210873)

Thu Jul 23 00:19:08 PDT 2026

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `flang-x86_64-windows` running on `minipc-ryzen-win` while building `flang` at step 6 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/166/builds/10159

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (build-unified-tree) failure: build (failure)
...
5.696 [3/6/124] Building C object CMakeFiles\clang_rt.builtins-x86_64.dir\truncdfbf2.c.obj
5.745 [2/6/125] Building C object CMakeFiles\clang_rt.builtins-x86_64.dir\truncxfbf2.c.obj
5.754 [1/6/126] Building C object CMakeFiles\clang_rt.builtins-x86_64.dir\enable_execute_stack.c.obj
5.902 [1/5/127] Building C object CMakeFiles\clang_rt.builtins-x86_64.dir\trunctfbf2.c.obj
5.908 [1/4/128] Building C object CMakeFiles\clang_rt.builtins-x86_64.dir\extendbfsf2.c.obj
5.914 [1/3/129] Building C object CMakeFiles\clang_rt.builtins-x86_64.dir\truncsfbf2.c.obj
6.544 [1/2/130] Building C object CMakeFiles\clang_rt.builtins-x86_64.dir\emutls.c.obj
6.922 [1/1/131] Building C object CMakeFiles\clang_rt.builtins-x86_64.dir\cpu_model\x86.c.obj
6.974 [0/1/132] Linking C static library C:\buildbot\flang-x86_64-windows\build\lib\clang\24\lib\windows\clang_rt.builtins-x86_64.lib
394.715 [2019/6/5708] Linking CXX executable bin\lli.exe
FAILED: [code=4294967295] bin/lli.exe 
C:\Windows\system32\cmd.exe /C "cd . && "C:\Program Files\CMake\bin\cmake.exe" -E vs_link_exe --msvc-ver=1951 --intdir=tools\lli\CMakeFiles\lli.dir --rc=C:\PROGRA~2\WI3CF2~1\10\bin\100261~1.0\x64\rc.exe --mt=C:\PROGRA~2\WI3CF2~1\10\bin\100261~1.0\x64\mt.exe --manifests  -- C:\PROGRA~1\MICROS~2\18\COMMUN~1\VC\Tools\MSVC\1451~1.362\bin\Hostx64\x64\link.exe /nologo tools\lli\CMakeFiles\lli.dir\lli.cpp.obj tools\lli\CMakeFiles\lli.dir\__\__\resources\windows_version_resource.rc.res  /out:bin\lli.exe /implib:lib\lli.lib /pdb:bin\lli.pdb /version:0.0 /machine:x64 /INCREMENTAL:NO /subsystem:console /STACK:10000000  lib\LLVMCodeGen.lib  lib\LLVMCore.lib  lib\LLVMExecutionEngine.lib  lib\LLVMIRReader.lib  lib\LLVMInterpreter.lib  lib\LLVMJITLink.lib  lib\LLVMMC.lib  lib\LLVMMCJIT.lib  lib\LLVMObject.lib  lib\LLVMOrcJIT.lib  lib\LLVMOrcDebugging.lib  lib\LLVMOrcShared.lib  lib\LLVMOrcTargetProcess.lib  lib\LLVMPasses.lib  lib\LLVMRuntimeDyld.lib  lib\LLVMSelectionDAG.lib  lib\LLVMSupport.lib  lib\LLVMTarget.lib  lib\LLVMTargetParser.lib  lib\LLVMTransformUtils.lib  lib\LLVMX86CodeGen.lib  lib\LLVMX86AsmParser.lib  lib\LLVMX86Desc.lib  lib\LLVMX86Disassembler.lib  lib\LLVMX86Info.lib  lib\LLVMCoroutines.lib  lib\LLVMHipStdPar.lib  lib\LLVMipo.lib  lib\LLVMFrontendOpenMP.lib  lib\LLVMFrontendOffloading.lib  lib\LLVMObjectYAML.lib  lib\LLVMFrontendAtomic.lib  lib\LLVMFrontendDirective.lib  lib\LLVMLinker.lib  lib\LLVMVectorize.lib  lib\LLVMSandboxIR.lib  lib\LLVMWindowsDriver.lib  lib\LLVMOption.lib  lib\LLVMCFGuard.lib  lib\LLVMGlobalISel.lib  lib\LLVMIRPrinter.lib  lib\LLVMInstrumentation.lib  lib\LLVMAsmPrinter.lib  lib\LLVMCGData.lib  lib\LLVMBitWriter.lib  lib\LLVMObjCARCOpts.lib  lib\LLVMScalarOpts.lib  lib\LLVMAggressiveInstCombine.lib  lib\LLVMInstCombine.lib  lib\LLVMAnalysis.lib  lib\LLVMFrontendHLSL.lib  lib\LLVMProfileData.lib  lib\LLVMSymbolize.lib  lib\LLVMDebugInfoGSYM.lib  lib\LLVMDebugInfoPDB.lib  lib\LLVMDebugInfoMSF.lib  lib\LLVMDebugInfoBTF.lib  lib\LLVMDebugInfoDWARF.lib  lib\LLVMAsmParser.lib  lib\LLVMBitReader.lib  lib\LLVMRemarks.lib  lib\LLVMBitstreamReader.lib  lib\LLVMTextAPI.lib  lib\LLVMDebugInfoCodeView.lib  lib\LLVMCodeGenTypes.lib  lib\LLVMMCParser.lib  lib\LLVMMCDisassembler.lib  lib\LLVMDebugInfoDWARFLowLevel.lib  lib\LLVMBinaryFormat.lib  lib\LLVMDemangle.lib  psapi.lib  shell32.lib  ole32.lib  uuid.lib  advapi32.lib  ws2_32.lib  ntdll.lib  delayimp.lib  -delayload:shell32.dll  -delayload:ole32.dll  kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib && cd ."
LINK: command "C:\PROGRA~1\MICROS~2\18\COMMUN~1\VC\Tools\MSVC\1451~1.362\bin\Hostx64\x64\link.exe /nologo tools\lli\CMakeFiles\lli.dir\lli.cpp.obj tools\lli\CMakeFiles\lli.dir\__\__\resources\windows_version_resource.rc.res /out:bin\lli.exe /implib:lib\lli.lib /pdb:bin\lli.pdb /version:0.0 /machine:x64 /INCREMENTAL:NO /subsystem:console /STACK:10000000 lib\LLVMCodeGen.lib lib\LLVMCore.lib lib\LLVMExecutionEngine.lib lib\LLVMIRReader.lib lib\LLVMInterpreter.lib lib\LLVMJITLink.lib lib\LLVMMC.lib lib\LLVMMCJIT.lib lib\LLVMObject.lib lib\LLVMOrcJIT.lib lib\LLVMOrcDebugging.lib lib\LLVMOrcShared.lib lib\LLVMOrcTargetProcess.lib lib\LLVMPasses.lib lib\LLVMRuntimeDyld.lib lib\LLVMSelectionDAG.lib lib\LLVMSupport.lib lib\LLVMTarget.lib lib\LLVMTargetParser.lib lib\LLVMTransformUtils.lib lib\LLVMX86CodeGen.lib lib\LLVMX86AsmParser.lib lib\LLVMX86Desc.lib lib\LLVMX86Disassembler.lib lib\LLVMX86Info.lib lib\LLVMCoroutines.lib lib\LLVMHipStdPar.lib lib\LLVMipo.lib lib\LLVMFrontendOpenMP.lib lib\LLVMFrontendOffloading.lib lib\LLVMObjectYAML.lib lib\LLVMFrontendAtomic.lib lib\LLVMFrontendDirective.lib lib\LLVMLinker.lib lib\LLVMVectorize.lib lib\LLVMSandboxIR.lib lib\LLVMWindowsDriver.lib lib\LLVMOption.lib lib\LLVMCFGuard.lib lib\LLVMGlobalISel.lib lib\LLVMIRPrinter.lib lib\LLVMInstrumentation.lib lib\LLVMAsmPrinter.lib lib\LLVMCGData.lib lib\LLVMBitWriter.lib lib\LLVMObjCARCOpts.lib lib\LLVMScalarOpts.lib lib\LLVMAggressiveInstCombine.lib lib\LLVMInstCombine.lib lib\LLVMAnalysis.lib lib\LLVMFrontendHLSL.lib lib\LLVMProfileData.lib lib\LLVMSymbolize.lib lib\LLVMDebugInfoGSYM.lib lib\LLVMDebugInfoPDB.lib lib\LLVMDebugInfoMSF.lib lib\LLVMDebugInfoBTF.lib lib\LLVMDebugInfoDWARF.lib lib\LLVMAsmParser.lib lib\LLVMBitReader.lib lib\LLVMRemarks.lib lib\LLVMBitstreamReader.lib lib\LLVMTextAPI.lib lib\LLVMDebugInfoCodeView.lib lib\LLVMCodeGenTypes.lib lib\LLVMMCParser.lib lib\LLVMMCDisassembler.lib lib\LLVMDebugInfoDWARFLowLevel.lib lib\LLVMBinaryFormat.lib lib\LLVMDemangle.lib psapi.lib shell32.lib ole32.lib uuid.lib advapi32.lib ws2_32.lib ntdll.lib delayimp.lib -delayload:shell32.dll -delayload:ole32.dll kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST:EMBED,ID=1" failed (exit code 1190) with the following output:

LLVMOrcJIT.lib(LinkGraphLinkingLayer.cpp.obj) : fatal error LNK1190: invalid fixup found, type 0x0403

395.378 [2019/4/5710] Linking CXX executable bin\llvm-cov.exe
406.956 [2019/2/5712] Building CXX object tools\flang\lib\Optimizer\Support\CMakeFiles\FIRSupport.dir\Utils.cpp.obj
460.250 [2019/1/5713] Building CXX object tools\flang\lib\Optimizer\Dialect\CMakeFiles\FIRDialect.dir\FIROps.cpp.obj
tools\flang\include\flang/Optimizer/Dialect/CanonicalizationPatterns.inc(447): warning C4927: illegal conversion; more than one user-defined conversion has been implicitly applied
ninja: build stopped: subcommand failed.
Cache directory:       C:\Users\buildbot-worker\AppData\Local\ccache
Config file:           C:\Users\buildbot-worker\AppData\Local\ccache\ccache.conf
Directory config file:
System config file:    C:\ProgramData\ccache\ccache.conf
Stats updated:         07/23/26 00:18:30
Cacheable calls:        3789 / 3789 (100.0%)
  Hits:                 3623 / 3789 (95.62%)
    Direct:             3494 / 3623 (96.44%)
    Preprocessed:        129 / 3623 ( 3.56%)
  Misses:                166 / 3789 ( 4.38%)
Successful lookups:
  Direct:               3494 / 3789 (92.21%)
  Preprocessed:          129 /  295 (43.73%)
Local storage:
  Cache size (GB):       5.0 /  5.0 (99.29%)
  Files:               22058
  Cleanups:                7
  Hits:                 3642 / 3808 (95.64%)
  Misses:                166 / 3808 ( 4.36%)
  Reads:                7712
  Writes:                327

```

</details>

https://github.com/llvm/llvm-project/pull/210873