[flang-commits] [flang] [flang][PFT-to-MLIR] lazily allocate label-target blocks in branch lowering (PR #210950)

[via flang-commits]

https://github.com/jeanPerier commented:

I think that if we leave it up to the consumers to call getOrCreateEvalBlock, we may miss cases.

Do a Select Rank/Type/Case work OK inside omp regions for instance? They seem to have the same kinds of asserts: https://github.com/llvm/llvm-project/blob/17ac8fdd95283110a14f1de8c15a0fc661119296/flang/lib/Lower/Bridge.cpp#L4457

What do you think about updating directives common createEmptyRegionBlocks so that it will create the blocks if they have not been created yet? Or maybe createEmptyBlocks should now visit the whole tree, although that is more expensive.

I am not fundamentally opposed to the lazy approach, but maybe it needs to be a bit more systematic. 

https://github.com/llvm/llvm-project/pull/210950