[flang-commits] [flang] [flang][OpenMP] Add semantic checks for two DECLARE VARIANT restrictions (PR #209528)

[Abid Qadeer via flang-commits]

================
@@ -878,6 +878,33 @@ static bool CheckVariantAccessibility(SemanticsContext &context,
   return false;
 }
 
+// Collect the construct selector set of `sel` into `constructs` as an ordered
+// list of leaf construct directives. Combined and composite constructs are
+// decomposed into their leaves (e.g. `target teams` -> target, teams), so two
+// match selectors have the same construct selector set iff the collected lists
+// are equal. An absent construct selector yields an empty list.
+static void CollectConstructSelectorSet(
----------------
abidh wrote:

Thanks for pointing it out. I have fixed it now.  Also note that my latest change compares construct selector sets for *equality* (OpenMP [7.5]), not for matching. The simdlen matching rule (a simdlen(N) selector matches a simdlen(M) context when M % N == 0) is a separate, resolution-time concern; here simdlen(4) and simdlen(8) simply count as different selector sets.

https://github.com/llvm/llvm-project/pull/209528