[flang-commits] [flang] [Flang] [OpenMP] Run `MarkDeclareTarget` pass again after `ConvertMathToFuncs` (PR #210049)
Sergio Afonso via flang-commits
flang-commits at lists.llvm.org
Thu Jul 16 06:28:48 PDT 2026
https://github.com/skatrak commented:
Thank you @skadewdl3, for the detailed troubleshooting and the fix.
Before merging, I think it would be a good idea to add a small Lit test (in `flang/test/Integration/OpenMP/`) based on the reproducer in the issue, to avoid inadvertently breaking it later on.
Also, I'd suggest updating the PR description to state that the pass is added before `HostOpFiltering` rather than after `ConvertMathToFuncs`, so it is more precise about what it does.
https://github.com/llvm/llvm-project/pull/210049
More information about the flang-commits
mailing list