[flang-commits] [flang] [flang][OpenMP] Lower multi-type user-defined declare reduction (PR #207494)

[Tom Eccles via flang-commits]

================
@@ -4518,7 +4519,11 @@ static ReductionProcessor::GenCombinerCBTy processReductionCombiner(
         assign = &*wrapper->v;
   }
   ReductionProcessor::GenCombinerCBTy genCombinerCB;
-  const StylizedInstance &inst = combiner.v.front();
+  // Use the combiner instance for the type currently being lowered (one per
+  // listed type, in typeNameList order): a multi-type declare reduction carries
+  // a distinct stylized instance per type so omp_out/omp_in are re-typed for
+  // each. Single-type is index 0 of one.
+  const StylizedInstance &inst = combinerInst;
----------------
tblah wrote:

nit: maybe the variable should just be renamed.

https://github.com/llvm/llvm-project/pull/207494