[flang-commits] [flang] [flang][OpenMP] Lowering support for declare variant. (PR #206988)

[Abid Qadeer via flang-commits]

abidh wrote:

> Is there any reason why you have not included Integration tests (flang/test/Integration/OpenMP/)?

In Flang, tests are generally added at the level where the behavior is observable, and flang/test/Integration/ is used only sparingly. Its own guidance (README.md) says that "We should only add tests here sparingly and only if there is no other way to test".

For DECLARE VARIANT,  whether a call targets the base or the variant is fully visible in the FIR that lowering produces. So lowering tests cover the feature completely and an Integration test isn't needed here. That said, I'm happy to add an integration test if there's a scenario it would cover that the lowering tests can't.

https://github.com/llvm/llvm-project/pull/206988