[flang-commits] [flang] [llvm] [flang] Implement 'F_C_STRING' library function (Fortran 2023) (PR #174474)

[Caroline Newcombe via flang-commits]

================
@@ -93,6 +93,10 @@ void RTDECL(Repeat)(Descriptor &result, const Descriptor &string,
 void RTDECL(Trim)(Descriptor &result, const Descriptor &string,
     const char *sourceFile = nullptr, int sourceLine = 0);
 
+void RTDECL(FCString)(Descriptor &result, const Descriptor &string,
+    const Descriptor *asis /*can be null*/, const char *sourceFile = nullptr,
----------------
cenewcombe wrote:

I wanted to point out that the comment approach is consistent with optional arguments for other intrinsics in this file (e.g., Index, Scan, Verify) -- I wrote it this way to match the others. If you still prefer the default value, I'm happy to make the change.

https://github.com/llvm/llvm-project/pull/174474