[flang-commits] [flang] [flang][driver] Improve diagnostic for assembly inputs (PR #174316)
Tarun Prabhu via flang-commits
flang-commits at lists.llvm.org
Wed Jan 14 07:13:32 PST 2026
================
@@ -83,6 +83,32 @@ static void ExpandResponseFiles(llvm::StringSaver &saver,
}
}
+static bool rejectAssemblyInputs(const llvm::opt::ArgList &Args,
+ clang::DiagnosticsEngine &Diags) {
+
+ for (const llvm::opt::Arg *Arg : Args) {
+ if (Arg->getOption().getKind() != llvm::opt::Option::InputClass)
+ continue;
+
+ llvm::StringRef Filename(Arg->getValue());
+
----------------
tarunprabhu wrote:
There are too many empty lineshere. This makes the code harder to read. Generally, it is good to "group" lines of code together that are "related" in some way with empty lines separating such groups. They can also be used to separate related code if the code is too dense.
Here, the code is not particularly dense, so there is no need to have empty lines. Particularly since the code in lines 93 - 106 is all related. This is a matter of style, and there is no "right way".
```suggestion
```
https://github.com/llvm/llvm-project/pull/174316
More information about the flang-commits
mailing list