[flang-commits] [flang] [llvm] [flang][MIF] Adding Stop and ErrorStop operations (PR #166787)

[Dan Bonachea via flang-commits]

================
@@ -15,8 +15,8 @@
 struct EnvironmentDefaultList;
 
 FORTRAN_EXTERN_C_BEGIN
-void RTNAME(ProgramStart)(
-    int, const char *[], const char *[], const struct EnvironmentDefaultList *);
+void RTNAME(ProgramStart)(int, const char *[], const char *[],
+    const struct EnvironmentDefaultList *, const bool multiImageInitialized);
----------------
bonachea wrote:

This change appears to be responsible for a [CI failure](https://github.com/llvm/llvm-project/actions/runs/20961343796/job/60239171868?pr=166787) in flang-rt/unittests/Runtime/CommandTest.cpp, which directly invokes `RTNAME(ProgramStart)`:

```
  /home/gha/actions-runner/_work/llvm-project/llvm-project/flang-rt/unittests/Runtime/CommandTest.cpp:70:5: error: no matching function for call to '_FortranAProgramStart'
     70 |     RTNAME(ProgramStart)(argc, argv, {}, {});
        |     ^~~~~~~~~~~~~~~~~~~~
  /home/gha/actions-runner/_work/llvm-project/llvm-project/flang-rt/../flang/include/flang/Runtime/entry-names.h:27:22: note: expanded from macro 'RTNAME'
     27 | #define RTNAME(name) NAME_WITH_PREFIX_AND_REVISION(_Fortran, A, name)
        |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  /home/gha/actions-runner/_work/llvm-project/llvm-project/flang-rt/../flang/include/flang/Runtime/entry-names.h:26:3: note: expanded from macro 'NAME_WITH_PREFIX_AND_REVISION'
     26 |   prefix##revision##name
        |   ^~~~~~~~~~~~~~~~~~~~~~
  <scratch space>:155:1: note: expanded from here
    155 | _FortranAProgramStart
        | ^~~~~~~~~~~~~~~~~~~~~
  /home/gha/actions-runner/_work/llvm-project/llvm-project/flang-rt/../flang/include/flang/Runtime/main.h:18:6: note: candidate function not viable: requires 5 arguments, but 4 were provided
```

That unit test probably needs to be updated for the new signature.

https://github.com/llvm/llvm-project/pull/166787