[flang-commits] [flang] [flang] Fix one legitimate warning found with -Werror (PR #175819)

[Peter Klausler via flang-commits]

klausler wrote:

> > PR updated to just fix one bug found via -Werror, leaving the other warning alone and leaving -Werror off by default.
> 
> Keeping it off by default SGTM. We already enable it by default in premerge CI given we use the latest clang there, so that should catch most of the issues. I'm not sure what other configurations flang cares about being warning free in. Is it possible to just enable it on specific buildbots where there is control over the toolchain used?

I'm surprised to hear that -Werror is on for pre-merge CI of flang-new; it hasn't worked for me in my extremely plain vanilla Linux development environments since late September, until I started cleaning up some warnings recently so that I could re-enable -Werror locally.

https://github.com/llvm/llvm-project/pull/175819