[flang-commits] [flang] [flang] Turn -Werror back off for Flang build (PR #175689)

[via flang-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-flang-semantics

Author: Peter Klausler (klausler)

<details>
<summary>Changes</summary>

Different build environments are picking up warnings that my testing didn't expose; turn -Werror back off.
(And also delete an unused data member that was triggering some MSVC warnings.)

---
Full diff: https://github.com/llvm/llvm-project/pull/175689.diff


2 Files Affected:

- (modified) flang/CMakeLists.txt (+1-1) 
- (modified) flang/include/flang/Semantics/expression.h (-1) 


``````````diff
diff --git a/flang/CMakeLists.txt b/flang/CMakeLists.txt
index 390cfe749f962..c01eb56d5e496 100644
--- a/flang/CMakeLists.txt
+++ b/flang/CMakeLists.txt
@@ -37,7 +37,7 @@ if (CMAKE_SOURCE_DIR STREQUAL CMAKE_BINARY_DIR AND NOT MSVC_IDE)
           `CMakeFiles'. Please delete them.")
 endif()
 
-option(FLANG_ENABLE_WERROR "Fail and stop building flang if a warning is triggered." ON)
+option(FLANG_ENABLE_WERROR "Fail and stop building flang if a warning is triggered." OFF)
 
 # Check for a standalone build and configure as appropriate from
 # there.
diff --git a/flang/include/flang/Semantics/expression.h b/flang/include/flang/Semantics/expression.h
index 3392b797c311e..50f75b2304d95 100644
--- a/flang/include/flang/Semantics/expression.h
+++ b/flang/include/flang/Semantics/expression.h
@@ -429,7 +429,6 @@ class ExpressionAnalyzer {
   bool inDataStmtConstant_{false};
   bool inStmtFunctionDefinition_{false};
   bool iterativelyAnalyzingSubexpressions_{false};
-  bool inDeadCode_{false};
   friend class ArgumentAnalyzer;
 };
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/175689