[flang-commits] [flang] [flang][driver] Improve diagnostic for assembly inputs (PR #174316)

[Tarun Prabhu via flang-commits]

https://github.com/tarunprabhu requested changes to this pull request.

Thanks for the update. This is looking quite a bit better. I am still not convinced that this is the best place to check for input assembly files, but a better one does not immediately come to mind, so let's leave it here for the time being.

In that case, could you move your code into a separate function? This code is inherently "temporary" since we would like to have flang handle assembly files eventually (particularly since clang can already do so).  In that case, moving this code to a separate function will keep the original logic relatively clean, and also provide a self-contained unit that can be easily removed when this support is added. 

What do you think?

https://github.com/llvm/llvm-project/pull/174316