[flang-commits] [flang] [llvm] [llvm][flang] Silence warning, resume -Werror builds of flang (PR #175053)

[via flang-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

* 129256 tests passed
* 2852 tests skipped

All executed tests passed, but another part of the build **failed**. Click on a failure below to see the details.

<details>
<summary>[code=1] tools/flang/lib/Evaluate/CMakeFiles/FortranEvaluate.dir/fold-real.cpp.obj</summary>

```
FAILED: [code=1] tools/flang/lib/Evaluate/CMakeFiles/FortranEvaluate.dir/fold-real.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DFLANG_INCLUDE_TESTS=1 -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools\flang\lib\Evaluate -IC:\_work\llvm-project\llvm-project\flang\lib\Evaluate -IC:\_work\llvm-project\llvm-project\flang\include -Itools\flang\include -Iinclude -IC:\_work\llvm-project\llvm-project\llvm\include -imsvc C:\_work\llvm-project\llvm-project\flang\..\mlir\include -imsvc tools\mlir\include -imsvc tools\clang\include -imsvc C:\_work\llvm-project\llvm-project\llvm\..\clang\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw /WX -Wno-deprecated-copy -Wno-string-conversion -Wno-ctad-maybe-unsupported -Xclang -fno-pch-timestamp /O2 /Ob2  -MD -UNDEBUG /EHs-c- /GR- -std:c++17 /YuC:/_work/llvm-project/llvm-project/build/tools/flang/lib/Evaluate/CMakeFiles/FortranEvaluate.dir/cmake_pch.hxx /FpC:/_work/llvm-project/llvm-project/build/tools/flang/lib/Evaluate/CMakeFiles/FortranEvaluate.dir/./cmake_pch.cxx.pch /FIC:/_work/llvm-project/llvm-project/build/tools/flang/lib/Evaluate/CMakeFiles/FortranEvaluate.dir/cmake_pch.hxx /showIncludes /Fotools\flang\lib\Evaluate\CMakeFiles\FortranEvaluate.dir\fold-real.cpp.obj /Fdtools\flang\lib\Evaluate\CMakeFiles\FortranEvaluate.dir\FortranEvaluate.pdb -c -- C:\_work\llvm-project\llvm-project\flang\lib\Evaluate\fold-real.cpp
C:\_work\llvm-project\llvm-project\flang\lib\Evaluate\fold-real.cpp(396,27): error: use 'template' keyword to treat 'SCALE' as a dependent template name [-Werror]
396 |                           SCALE<Scalar<TBY>>(y)};
|                           ^
|                           template
1 error generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/175053