[flang-commits] [flang] [Flang] Adjust pass plugin support to match Clang (PR #174006)

[Andrzej Warzyński via flang-commits]

================
@@ -0,0 +1,26 @@
+! Verify that the static and dynamically loaded pass plugins work as expected.
+
+! UNSUPPORTED: system-windows
+
+! REQUIRES: plugins, shell, examples
+
+! RUN: %flang_fc1 -S %s -o - %loadbye \
+! RUN: 2>&1 | FileCheck %s --check-prefix=CHECK-INACTIVE
+
+! RUN: %flang_fc1 -S %s -o - %loadbye -mllvm -last-words \
+! RUN: | FileCheck %s --check-prefix=CHECK-ACTIVE
+
+! RUN: %flang_fc1 -emit-llvm %s -o - %loadbye -mllvm -last-words \
----------------
banach-space wrote:

Seconding @tarunprabhu - it's not clear to me what this is testing. Specifically, what's `INACTIVE` and what's `ACTIVE`? Please add more comments and clarify the difference between this test and pass-plugin.f90. 

Btw, I've noticed that you copied the original comment:
> ! Verify that the static and dynamically loaded pass plugins work as expected.

I find it very enigmatic. As an expert, could you replace it with some more detail? Thanks! 🙏🏻 

https://github.com/llvm/llvm-project/pull/174006