[flang-commits] [clang] [flang] [llvm] [mlir] [polly] [CMake][LLVM] Add PCH infrastructure and LLVMSupport PCH (PR #176420)

[Mikael Holmen via flang-commits]

mikaelholmen wrote:

> > @vitalybuka #182529 fixed/should fix these. MLIR+ASan failures seem unrelated.
> 
> They are related:
> 
> BAD: https://lab.llvm.org/buildbot/#/builders/52/builds/15222 NO PCH: [llvm/llvm-zorg at 998f4b8](https://github.com/llvm/llvm-zorg/commit/998f4b86c07f82705fd603f07eca39a5154bf717) GOOD: https://lab.llvm.org/buildbot/#/builders/52/builds/15223
> 
> Errors looks like this:
> 
> https://lab.llvm.org/buildbot/#/builders/169/builds/20215
> 
> ```
> ==mlir-runner==3500971==HINT: if you don't care about these errors you may set ASAN_OPTIONS=detect_odr_violation=0
> SUMMARY: AddressSanitizer: odr-violation: global 'llvm::EnableABIBreakingChecks' at /home/b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Support/ABIBreak.cpp in /home/b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/lib/../lib/libmlir_float16_utils.so.23.0git

Indeed they are related.
When I do a local ASan build I get ~225 new MLIR lit test failures as above with this patch and I still get them at f89067041.

https://github.com/llvm/llvm-project/pull/176420