[flang-commits] [flang] [flang][OpenMP] Remove unused internal functions. (PR #180625)

[Sergio Afonso via flang-commits]

https://github.com/skatrak commented:

Thank you Abid. If my understanding is correct, this only addresses the cases like those in the linked issue, but not others like the ones addressed by #178937. If that's the case, then I'm not sure there's much value in splitting the logic into different places.

My suggestion would be, since as you commented on the other PR that it's preferable to keep the unreachable `omp.target` deletion logic as a standalone pass and not to integrate it into `FunctionFiltering`, this patch should also be part of it (maybe make it a PR stack if you prefer to keep both separate or just integrate this logic there). We just have to make sure that it runs before `FunctionFiltering`, so we won't keep around host functions that only contain unreachable target regions when compiling for an offloading target.

https://github.com/llvm/llvm-project/pull/180625