[flang-commits] [flang] [flang][OpenMP] Fix declare target attribute for USE-associated module globals (PR #218339)

[via flang-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Windows-->
# :window: Windows x64 Test Results

The build failed before running any tests. Click on a failure below to see the details.

<details>
<summary>[code=1] tools/flang/lib/Lower/CMakeFiles/FortranLower.dir/ConvertVariable.cpp.obj</summary>

```
FAILED: [code=1] tools/flang/lib/Lower/CMakeFiles/FortranLower.dir/ConvertVariable.cpp.obj
sccache C:\clang\clang-msvc\bin\clang-cl.exe  /nologo -TP -DFLANG_INCLUDE_TESTS=1 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_EXTENSIVE -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:\_work\llvm-project\llvm-project\build\tools\flang\lib\Lower -IC:\_work\llvm-project\llvm-project\flang\lib\Lower -IC:\_work\llvm-project\llvm-project\flang\include -IC:\_work\llvm-project\llvm-project\build\tools\flang\include -IC:\_work\llvm-project\llvm-project\build\include -IC:\_work\llvm-project\llvm-project\llvm\include -imsvcC:\_work\llvm-project\llvm-project\flang\..\mlir\include -imsvcC:\_work\llvm-project\llvm-project\build\tools\mlir\include -imsvcC:\_work\llvm-project\llvm-project\build\tools\clang\include -imsvcC:\_work\llvm-project\llvm-project\llvm\..\clang\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:__cplusplus /Oi /Brepro /bigobj /permissive- -Werror=unguarded-availability-new /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported /Gw -Wno-deprecated-copy -Wno-string-conversion -Wno-ctad-maybe-unsupported /O2 /Ob2  -std:c++17 -MD -UNDEBUG /EHs-c- /GR- /showIncludes /Fotools\flang\lib\Lower\CMakeFiles\FortranLower.dir\ConvertVariable.cpp.obj /Fdtools\flang\lib\Lower\CMakeFiles\FortranLower.dir\FortranLower.pdb -c -- C:\_work\llvm-project\llvm-project\flang\lib\Lower\ConvertVariable.cpp
C:\_work\llvm-project\llvm-project\flang\lib\Lower\ConvertVariable.cpp(238,53): error: too few arguments to function call, expected 4, have 3
237 |   declareTargetOp.setDeclareTarget(deviceType, captureClause,
|   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
238 |                                    /*automap=*/false);
|                                                     ^
C:\_work\llvm-project\llvm-project\build\tools\mlir\include\mlir/Dialect/OpenMP/OpenMPOpsInterfaces.h.inc(692,8): note: 'setDeclareTarget' declared here
692 |   void setDeclareTarget(mlir::omp::DeclareTargetDeviceType deviceType, mlir::omp::DeclareTargetCaptureClause captureClause, bool automap, bool implicit);
|        ^                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/218339