[flang-commits] [clang] [flang] [llvm] CodeGen: Remove TargetOptions::FloatABIType (PR #215796)

[Alan Phipps via flang-commits]

evodius96 wrote:

> This commit results in massive failures with existing LIT tests for our downstream toolchains, especially for Arm, similar to what others have reported above. We do use our own driver code, but I'm not sure where to begin to pinpoint what needs to be changed. Can you point me where to get started?

Many of the failures are for Generic, which I think you also noted as being problematic, e.g.:

```
******************* TEST 'LLVM :: DebugInfo/Generic/linkage-name-abstract.ll' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
./bin/llc -O0 -filetype=obj -dwarf-linkage-names=Abstract < /scratch/aphipps/triage_repo/tools/llvm_cgt/llvm-project/llvm/test/DebugInfo/Generic/linkage-name-abstract.ll | ./bin/llvm-dwarfdump -debug-info - > ./test/ARM_LLVM/DebugInfo/Generic/Output/linkage-name-abstract.ll.tmp
# executed command: ./bin/llc -O0 -filetype=obj -dwarf-linkage-names=Abstract
# .---command stderr------------
# | error: linkage-name-abstract-static.cpp:2:0: in function _Z2f2v void (): calling convention is hard-float, but floating-point registers are unavailable
# |
# | error: linkage-name-abstract-static.cpp:5:0: in function _Z2f3v void (): calling convention is hard-float, but floating-point registers are unavailable
# |
# | error: linkage-name-abstract-static.cpp:12:0: in function _ZN2F42f5Ev void (): calling convention is hard-float, but floating-point registers are unavailable
# |
# | error: linkage-name-abstract-static.cpp:15:0: in function _Z2f6v void (): calling convention is hard-float, but floating-point registers are unavailable
# |
# `-----------------------------
# error: command failed with exit status: 1
# executed command: ./bin/llvm-dwarfdump -debug-info -
# .---command stderr------------
# | error: -: The file was not recognized as a valid object file
# `-----------------------------
# error: command failed with exit status: 1
```


https://github.com/llvm/llvm-project/pull/215796