[flang-commits] [flang] [flang][OpenMP] Diagnose privatized array section reductions (PR #215997)

[Tom Eccles via flang-commits]

================
@@ -4922,14 +4919,16 @@ static mlir::omp::TaskloopContextOp genStandaloneTaskloop(
                            enableDelayedPrivatization, symTable);
   dsp.processStep1(&taskloopClauseOps);
 
-  if (hasPrivatizedArrayElementReduction(inReductionObjects,
-                                         dsp.getAllSymbolsToPrivatize()))
-    TODO(loc, "TASKLOOP construct with IN_REDUCTION of an array element whose "
-              "base array is privatized");
-  if (hasPrivatizedArrayElementReduction(reductionObjects,
-                                         dsp.getAllSymbolsToPrivatize()))
-    TODO(loc, "TASKLOOP construct with REDUCTION of an array element whose "
-              "base array is privatized");
+  if (hasPrivatizedArrayReductionObject(inReductionObjects,
+                                        dsp.getDelayedPrivSymbols()))
+    TODO(loc,
+         "TASKLOOP construct with IN_REDUCTION of an array element or section "
+         "whose base array is privatized");
+  if (hasPrivatizedArrayReductionObject(reductionObjects,
+                                        dsp.getDelayedPrivSymbols()))
----------------
tblah wrote:

Sorry I think this got confusing because there were multiple commits in between. This was fixed by https://github.com/llvm/llvm-project/pull/215997/changes/e9cc76e7d2cc95ecc96627ad6f44a3e87d2b2ba2, then there was another follow up for a bug I found in AI review: https://github.com/llvm/llvm-project/pull/215997/commits/1ccac374d59e4027eab245b142efb9edd0b52037

https://github.com/llvm/llvm-project/pull/215997