[flang-commits] [flang] [flang][OpenMP] Detect conflicting data-sharing clauses for common blocks (PR #213913)
via flang-commits
flang-commits at lists.llvm.org
Mon Aug 17 04:31:02 PDT 2026
ejose02 wrote:
@phi-bee , Thanks for the review.
I have added a commit addressing the concerns:
- Folded the firstprivate/lastprivate pair check into WithMultipleAppearancesOmpException(..., prevFlag) and removed the separate helper.
- The common-block member loop now uses that single call with FindObjectWithDSAByUltimate(member) when a prior clause recorded DSA on a different Symbol*
- I kept ultimate-based lookup scoped to this helper rather than extending FindSymbolWithDSA() globally, since that function is also used by OpenACC and other paths and changing it caused CI failures when I tried that approach earlier.
https://github.com/llvm/llvm-project/pull/213913
More information about the flang-commits
mailing list