[flang-commits] [flang] [mlir] [Flang][OpenMP] Privatize descriptors for assumed shape array maps for performance increase (PR #212336)

[Pranav Bhandarkar via flang-commits]

================
@@ -349,8 +350,13 @@ class MapInfoFinalizationPass
 
     canDescBeDeferred = canDeferDescriptorMapping(descriptor);
 
-    if (!mlir::isa<fir::BaseBoxType>(descriptor.getType()) &&
-        !fir::factory::isOptionalArgument(descriptor.getDefiningOp()))
+    // A restricted subset of canDeferDescriptorMapping for the moment
----------------
bhandarkar-pranav wrote:

NIT: This reads a little strange because the sentence needs to be broken up. Please consider "For the moment, this is a restricted subset of canDeferDescriptorMapping. We can extend to encompass more cases we find acceptable cases" 
Or more verbose
"We defer descriptor mapping until target or target data regions for non-allocatable, non-pointer type dummy arguments with assumed type or shape. We choose to optimize via privatization a subset of these cases. We can extend to assumed types in the future if we needed"

https://github.com/llvm/llvm-project/pull/212336