[flang-commits] [flang] [flang][openmp] Support importing module declare target globals (PR #213930)
Sergio Afonso via flang-commits
flang-commits at lists.llvm.org
Mon Aug 10 04:38:54 PDT 2026
https://github.com/skatrak commented:
Thanks, this mostly LGTM.
Apart from a small suggestion, I'm also seeing that there's no proper testing for the features added by this PR. The only thing being tested comes from the parent PR, which is that `declare target` data gets added to the .mod file. We need to also check that a global accessed via a `USE`d external module also gets that information. @sbryngelson's PR #214596 adds one such unit test you could probably use.
https://github.com/llvm/llvm-project/pull/213930
More information about the flang-commits
mailing list