[flang-commits] [flang] [Flang] Coarray allocation, update error for pointer component #193829 (PR #194651)

[Dan Bonachea via flang-commits]

bonachea wrote:

> > I don't know where to find the original test programs mentioned in #193829.
> 
> I added the file links to the issue.

Thanks!
I've now reproduced the original compiler abort with 23.1.0-rc2:
```
cgpu$ flang --version
flang version 23.1.0-rc2
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /usr/local/pkg/clang/23.1.0-rc2/bin
cgpu$ flang -fcoarray 0907_0050.f90 
warning: Support for multi image Fortran features is still experimental and in development.
LLVM ERROR: aborting
cgpu$ flang -fcoarray 0907_0057.f90 
warning: Support for multi image Fortran features is still experimental and in development.
LLVM ERROR: aborting
```

And confirmed the correct, intended error message with flang built from this PR:
```cgpu$ flang-pr193829 -fcoarray 0907_0050.f90 
warning: Support for multi image Fortran features is still experimental and in development.
error: loc("<redacted>/0907_0050.f90":4:18): <redacted>/llvm/flang/lib/Lower/ConvertVariable.cpp:736: not yet implemented: Coarray with a pointer/allocatable direct component and/or requiring finalization.
LLVM ERROR: aborting
cgpu$ flang-pr193829 -fcoarray 0907_0057.f90 
warning: Support for multi image Fortran features is still experimental and in development.
error: loc("<redacted>/0907_0057.f90":4:13): <redacted>/llvm/flang/lib/Lower/ConvertVariable.cpp:736: not yet implemented: Coarray with a pointer/allocatable direct component and/or requiring finalization.
LLVM ERROR: aborting
```




https://github.com/llvm/llvm-project/pull/194651