[flang-commits] [clang] [flang] [mlir] [CIR][MLIR-LLVM] Add 'thread local mode/model' attribute support (PR #214337)

[Erich Keane via flang-commits]

erichkeane wrote:

I've added the new tests for import/export  in fb54de9 .  No surprises (well, 1 mild one?) that is a slight difference in behavior between the LLVMIR dialect and LLVM.

LLVMIR dialect (as in this patch) supports `thread_local(generaldynamic)` and `thread_local` to mean the same thing.  LLVM only supports the latter spelling to mean that (that is, no parenthesized version of the 'default' value).

I believe this to be acceptable, as it means the dialect is slightly more permissive as to what it takes in, but if you feel strongly, I can look into seeing if we can reject that case for the dialect.



https://github.com/llvm/llvm-project/pull/214337