[flang-commits] [clang] [flang] [mlir] [CIR][MLIR-LLVM] Add 'thread local mode/model' attribute support (PR #214337)

[Tobias Gysi via flang-commits]

================
@@ -2420,8 +2421,15 @@ static void printCommonGlobalAndAlias(OpAsmPrinter &p, OpType op) {
   StringRef visibility = stringifyVisibility(op.getVisibility_());
   if (!visibility.empty())
     p << visibility << ' ';
-  if (op.getThreadLocal_())
-    p << "thread_local ";
+
+  if (ThreadLocalMode mode = op.getTlsMode();
+      mode != ThreadLocalMode::NotThreadLocal) {
+    p << "thread_local";
+    if (mode != ThreadLocalMode::GeneralDynamic)
----------------
gysit wrote:

Is this necessary to avoid massive test changes? If we would start on a clean sheet I would definitely prefer to always print the enum value. 

https://github.com/llvm/llvm-project/pull/214337