[flang-commits] [flang] [flang] Add LLVM dialect dependency to VScaleAttr (PR #213931)

[via flang-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-flang-fir-hlfir

Author: Keshav Vinayak Jha (keshavvinayak01)

<details>
<summary>Changes</summary>

`VScaleAttr` creates an LLVM `VScaleRangeAttr`, but did not declare the LLVM dialect as a pass dependency. This aborts when the input does not otherwise load LLVM.

Declare the dependency and remove the unused FIR-typed argument from the existing test. Parsing `!fir.ref` loads `FIROpsDialect`, which loads `LLVMDialect` as a dependency and previously masked the missing pass dependency.

---
Full diff: https://github.com/llvm/llvm-project/pull/213931.diff


2 Files Affected:

- (modified) flang/include/flang/Optimizer/Transforms/Passes.td (+1) 
- (modified) flang/test/Transforms/vscale-attr.fir (+1-1) 


``````````diff
diff --git a/flang/include/flang/Optimizer/Transforms/Passes.td b/flang/include/flang/Optimizer/Transforms/Passes.td
index 9a1357881eae0..e7bb8ae9bb9bf 100644
--- a/flang/include/flang/Optimizer/Transforms/Passes.td
+++ b/flang/include/flang/Optimizer/Transforms/Passes.td
@@ -426,6 +426,7 @@ def VScaleAttr : Pass<"vscale-attr", "mlir::func::FuncOp"> {
      Set an attribute for the vscale range on functions, to allow scalable
      vector operations to be used on processors with variable vector length.
   }];
+  let dependentDialects = ["mlir::LLVM::LLVMDialect"];
   let options = [Option<"vscaleMin", "vscale-min", "unsigned", /*default=*/"1",
                         "vector scale minimum value. Defaults to \"1\"">,
                  Option<"vscaleMax", "vscale-max", "unsigned", /*default=*/"0",
diff --git a/flang/test/Transforms/vscale-attr.fir b/flang/test/Transforms/vscale-attr.fir
index 146b1af7c489f..657f6feb067fe 100644
--- a/flang/test/Transforms/vscale-attr.fir
+++ b/flang/test/Transforms/vscale-attr.fir
@@ -19,6 +19,6 @@
 // VSCALE-MIN-NO-PO2: VScaleAttr: vscaleMin has to be a power-of-two greater than 0
 // VSCALE-MAX-NO-PO2: VScaleAttr: vscaleMax has to be a power-of-two greater-than-or-equal to vscaleMin or 0 to signify an unbounded maximum
 // VSCALE-MIN-GREATER: VScaleAttr: vscaleMax has to be a power-of-two greater-than-or-equal to vscaleMin or 0 to signify an unbounded maximum
-func.func @_QPtest(%arg0: !fir.ref<i32> {fir.bindc_name = "x"}) {
+func.func @_QPtest() {
   return
 }

``````````

</details>


https://github.com/llvm/llvm-project/pull/213931