[flang-commits] [flang] [flang][Semantics] Avoid crash when pointer init follows PARAMETER with same name (PR #211604)

[Tom Eccles via flang-commits]

https://github.com/tblah commented:

Thank you for the patch, but I don't think this fixes the real issue.

This used the CHECK macro because it is a condition which should never occur: as much as anything, it is documenting an assumption made by the code. The fact that the object can in-fact already be initialized would indicate that there is some deeper bug.

The real problem is that something is getting initialized twice, and the existing code assumes that will never happen.

https://github.com/llvm/llvm-project/pull/211604