[flang-commits] [flang] [Flang][NFCI] Use abstraction for binary scalar data (PR #212956)

[Michael Kruse via flang-commits]

================

----------------
Meinersbur wrote:

Added `[[maybe_unused]]`

However, `CHECK` does not depend on NDEBUG. The comment for CHECK refers to disabling it by overriding it via the command line. That's a non-documented unusual convention.

I'd vote in favor of replacing them with standard `assert`.

https://github.com/llvm/llvm-project/pull/212956