[flang-commits] [flang] [mlir] [OpenMP][mlir] Add DynGroupPrivateClause in omp dialect (PR #153562)

[Sergio Afonso via flang-commits]

================
@@ -7164,11 +7186,20 @@ convertOmpTarget(Operation &opInst, llvm::IRBuilderBase &builder,
   if (Value targetIfCond = targetOp.getIfExpr())
     ifCond = moduleTranslation.lookupValue(targetIfCond);
 
+  Value dynGroupPrivateSize = targetOp.getDynGroupprivateSize();
+  llvm::Value *dynSizeVal = nullptr;
+  if (dynGroupPrivateSize)
+    dynSizeVal = moduleTranslation.lookupValue(dynGroupPrivateSize);
----------------
skatrak wrote:

Nit: Do users of this integer value expect it to be a specific size (e.g. `i32`)? If so, we need to make sure to create a typecast operation if we're using a different size. Either here or in the OMPIRBuilder, as at the moment this is not done by either.

I don't know if this is needed here, just a problem that has cropped up for other clauses before, when they are e.g. passed as function arguments.

https://github.com/llvm/llvm-project/pull/153562