[flang-commits] [flang] 9d704b4 - [flang][OpenMP] Remove unused member, NFC (#193512)

via flang-commits flang-commits at lists.llvm.org
Wed Apr 22 08:12:38 PDT 2026


Author: Krzysztof Parzyszek
Date: 2026-04-22T10:12:33-05:00
New Revision: 9d704b490d5aa1fc167a31d19ca1d39f2aabd265

URL: https://github.com/llvm/llvm-project/commit/9d704b490d5aa1fc167a31d19ca1d39f2aabd265
DIFF: https://github.com/llvm/llvm-project/commit/9d704b490d5aa1fc167a31d19ca1d39f2aabd265.diff

LOG: [flang][OpenMP] Remove unused member, NFC (#193512)

After e8e8b6a3d8616b5d6572f9e16442cc97ef3867bd, the member
`privateDataSharingAttributeObjects_` of OmpAttributeVisitor is no
longer used. Remove it and the associated accessor functions.

Added: 
    

Modified: 
    flang/lib/Semantics/resolve-directives.cpp

Removed: 
    


################################################################################
diff  --git a/flang/lib/Semantics/resolve-directives.cpp b/flang/lib/Semantics/resolve-directives.cpp
index 5bd5b980eb3c5..3fbd8e1ade347 100644
--- a/flang/lib/Semantics/resolve-directives.cpp
+++ b/flang/lib/Semantics/resolve-directives.cpp
@@ -1082,7 +1082,6 @@ class OmpAttributeVisitor : DirectiveAttributeVisitor<llvm::omp::Directive> {
   Symbol::Flags dataCopyingAttributeFlags{
       Symbol::Flag::OmpCopyIn, Symbol::Flag::OmpCopyPrivate};
 
-  UnorderedSymbolSet privateDataSharingAttributeObjects_; // on one directive
   UnorderedSymbolSet stmtFunctionExprSymbols_;
   std::multimap<const parser::Label,
       std::pair<parser::CharBlock, std::optional<DirContext>>>
@@ -1100,13 +1099,6 @@ class OmpAttributeVisitor : DirectiveAttributeVisitor<llvm::omp::Directive> {
   };
   std::vector<PartKind> partStack_;
 
-  void AddPrivateDataSharingAttributeObjects(SymbolRef object) {
-    privateDataSharingAttributeObjects_.insert(object);
-  }
-  void ClearPrivateDataSharingAttributeObjects() {
-    privateDataSharingAttributeObjects_.clear();
-  }
-
   // Predetermined DSA rules
   void PrivatizeAssociatedLoopIndex(const parser::OpenMPLoopConstruct &);
   void ResolveSeqLoopIndexInParallelOrTaskConstruct(const parser::Name &);
@@ -2015,7 +2007,6 @@ bool OmpAttributeVisitor::Pre(const parser::OmpBlockConstruct &x) {
   llvm::omp::Directive dirId{dirSpec.DirId()};
   PushContext(dirSpec.source, dirId);
   ClearDataSharingAttributeObjects();
-  ClearPrivateDataSharingAttributeObjects();
   return true;
 }
 
@@ -3145,9 +3136,6 @@ void OmpAttributeVisitor::CheckMultipleAppearances(
         name.ToString());
   } else {
     AddDataSharingAttributeObject(target->GetUltimate());
-    if (privateDataSharingAttributeFlags.test(ompFlag)) {
-      AddPrivateDataSharingAttributeObjects(*target);
-    }
   }
 }
 


        


More information about the flang-commits mailing list